NO-JIRA: test/e2e: improve VAP test assertions#5375
NO-JIRA: test/e2e: improve VAP test assertions#5375openshift-merge-bot[bot] merged 1 commit intomainfrom
Conversation
openshift-ci
bot
added
the
area/testing
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
approved
sjenning
changed the title
|
@sjenning: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
/test e2e-aws |
|
/retest |
|
self lgtm'ing and overriding to fix e2e |
|
@sjenning: Overrode contexts on behalf of sjenning: ci/prow/e2e-aws, ci/prow/e2e-kubevirt-aws-ovn-reduced DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@sjenning: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] Distgit: hypershift |
3 participants
openshift/cluster-network-operator#2612 broke our e2e because our assertions in
EnsureValidatingAdmissionPoliciesExistsmake the assumption that the only VAPs in the guest cluster are ones that we create.The PR refactors this check to:
after(), as in after the HostedCluster is fully deployed and the VAPs should already be created. It is a bug if they are not created by the time the check runs.